From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24104 invoked by alias); 29 Sep 2006 21:30:32 -0000 Received: (qmail 24095 invoked by uid 22791); 29 Sep 2006 21:30:30 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 29 Sep 2006 21:30:25 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k8TLULIV014924; Fri, 29 Sep 2006 23:30:21 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.8/8.13.6) with ESMTP id k8TLULno014721; Fri, 29 Sep 2006 23:30:21 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.8/8.13.8/Submit) id k8TLULvg002314; Fri, 29 Sep 2006 23:30:21 +0200 (CEST) Date: Fri, 29 Sep 2006 21:30:00 -0000 Message-Id: <200609292130.k8TLULvg002314@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: fnf@specifix.com CC: gdb-patches@sources.redhat.com In-reply-to: <200609291331.42865.fnf@specifix.com> (message from Fred Fish on Fri, 29 Sep 2006 13:31:42 -0700) Subject: Re: Include "defs.h" before other includes, for vec.c References: <200609291331.42865.fnf@specifix.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00213.txt.bz2 > From: Fred Fish > Date: Fri, 29 Sep 2006 13:31:42 -0700 > > This fixes a problem on solaris, where vec.h causes types.h to be pulled in, > but since _SYSCALL32 hasn't been defined yet (by config.h), off32_t doesn't > get defined. Then later, defs.h pulls in config.h, which defines _SYSCALL32, > and also causes fcntl.h to be pulled in, which sees _SYSCALL32 and tries > to use off32_t, which isn't defined. Heh, I just ran into this today. please commit if you didn't do so already. > 2006-09-29 Fred Fish > > * vec.c: Include defs.h first. This pulls in config.h which can > affect other includes.