Re: only force symbol lookups with local variables on hppa

[Daniel Jacobowitz <drow@false.org>]

On Sun, Aug 20, 2006 at 03:10:42PM +0200, Mark Kettenis wrote:
> > From: Mike Frysinger <vapier@gentoo.org>
> > Date: Sun, 20 Aug 2006 09:03:06 -0400
> > 
> > as a follow up to the slow script thread:
> > http://sources.redhat.com/ml/gdb/2006-08/msg00099.html
> > 
> > attached patch will change the behavior so symbols with dollar signs
> > in them0 ($) are only looked up when a specific arch says to do so
> > (with hppa being the only one at the moment)
> > -mike
> 
> > 2006-08-20  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* parse.c (write_dollar_variable): Check LOOKUP_DOLLAR_SYMBOLS.
> > 	* config/pa/tm-hppa.h [LOOKUP_DOLLAR_SYMBOLS]: Define.
> 
> Sorry but, this implementation is not acceptable; we want to get rid
> of all the defines in tm.h files (and the files themselves
> eventually), not add more :(.

As a followup, there are several better options:

  - Set a gdbarch hook.  See gdbarch.sh.
  - Keep track of the number of symbols found which start with
    a '$', probably in each objfile.  Only do the lookup if
    symbols starting with dollar have been found.
  - Just make partial symbol lookups faster.

-- 
Daniel Jacobowitz
CodeSourcery