From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6282 invoked by alias); 20 Aug 2006 13:58:04 -0000 Received: (qmail 6272 invoked by uid 22791); 20 Aug 2006 13:58:03 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 20 Aug 2006 13:57:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GEnoI-0004Vg-Rz; Sun, 20 Aug 2006 09:57:54 -0400 Date: Sun, 20 Aug 2006 14:38:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: vapier@gentoo.org, gdb-patches@sourceware.org Subject: Re: only force symbol lookups with local variables on hppa Message-ID: <20060820135754.GA17322@nevyn.them.org> Mail-Followup-To: Mark Kettenis , vapier@gentoo.org, gdb-patches@sourceware.org References: <200608200903.07185.vapier@gentoo.org> <200608201310.k7KDAgwj013347@elgar.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608201310.k7KDAgwj013347@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00137.txt.bz2 On Sun, Aug 20, 2006 at 03:10:42PM +0200, Mark Kettenis wrote: > > From: Mike Frysinger > > Date: Sun, 20 Aug 2006 09:03:06 -0400 > > > > as a follow up to the slow script thread: > > http://sources.redhat.com/ml/gdb/2006-08/msg00099.html > > > > attached patch will change the behavior so symbols with dollar signs > > in them0 ($) are only looked up when a specific arch says to do so > > (with hppa being the only one at the moment) > > -mike > > > 2006-08-20 Mike Frysinger > > > > * parse.c (write_dollar_variable): Check LOOKUP_DOLLAR_SYMBOLS. > > * config/pa/tm-hppa.h [LOOKUP_DOLLAR_SYMBOLS]: Define. > > Sorry but, this implementation is not acceptable; we want to get rid > of all the defines in tm.h files (and the files themselves > eventually), not add more :(. As a followup, there are several better options: - Set a gdbarch hook. See gdbarch.sh. - Keep track of the number of symbols found which start with a '$', probably in each objfile. Only do the lookup if symbols starting with dollar have been found. - Just make partial symbol lookups faster. -- Daniel Jacobowitz CodeSourcery