Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Recognize GCC pointer to member function DWARF2 descriptions
Date: Sat, 19 Aug 2006 03:22:00 -0000	[thread overview]
Message-ID: <20060818132642.GA24799@nevyn.them.org> (raw)
In-Reply-To: <200608180608.k7I68oUG019449@elgar.sibelius.xs4all.nl>

On Fri, Aug 18, 2006 at 08:08:50AM +0200, Mark Kettenis wrote:
> Could you add a reference to that GCC PR in a comment somewhere?  I
> think it'd be useul to know exactly what GCC issue is being worked
> around.

That's a good idea; done as attached.

-- 
Daniel Jacobowitz
CodeSourcery

2006-08-18  Daniel Jacobowitz  <dan@codesourcery.com>

	* dwarf2read.c (quirk_gcc_member_function_pointer): Add GCC PR
	number in a comment.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.202
diff -u -p -r1.202 dwarf2read.c
--- dwarf2read.c	18 Aug 2006 04:10:30 -0000	1.202
+++ dwarf2read.c	18 Aug 2006 13:25:31 -0000
@@ -3711,7 +3711,10 @@ is_vtable_name (const char *name, struct
 /* GCC outputs unnamed structures that are really pointers to member
    functions, with the ABI-specified layout.  If DIE (from CU) describes
    such a structure, set its type, and return nonzero.  Otherwise return
-   zero.  */
+   zero.
+
+   GCC shouldn't do this; it should just output pointer to member DIEs.
+   This is GCC PR debug/28767.  */
 
 static int
 quirk_gcc_member_function_pointer (struct die_info *die, struct dwarf2_cu *cu)


      reply	other threads:[~2006-08-18 13:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07  2:57 Daniel Jacobowitz
2006-08-18  9:21 ` Daniel Jacobowitz
2006-08-18 13:26   ` Mark Kettenis
2006-08-19  3:22     ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060818132642.GA24799@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox