From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22604 invoked by alias); 18 Aug 2006 13:26:49 -0000 Received: (qmail 22596 invoked by uid 22791); 18 Aug 2006 13:26:48 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 18 Aug 2006 13:26:45 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GE4N0-0006T4-QX; Fri, 18 Aug 2006 09:26:42 -0400 Date: Sat, 19 Aug 2006 03:22:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [rfc] Recognize GCC pointer to member function DWARF2 descriptions Message-ID: <20060818132642.GA24799@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20060807025740.GA3018@nevyn.them.org> <20060818041112.GB13020@nevyn.them.org> <200608180608.k7I68oUG019449@elgar.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608180608.k7I68oUG019449@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00124.txt.bz2 On Fri, Aug 18, 2006 at 08:08:50AM +0200, Mark Kettenis wrote: > Could you add a reference to that GCC PR in a comment somewhere? I > think it'd be useul to know exactly what GCC issue is being worked > around. That's a good idea; done as attached. -- Daniel Jacobowitz CodeSourcery 2006-08-18 Daniel Jacobowitz * dwarf2read.c (quirk_gcc_member_function_pointer): Add GCC PR number in a comment. Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.202 diff -u -p -r1.202 dwarf2read.c --- dwarf2read.c 18 Aug 2006 04:10:30 -0000 1.202 +++ dwarf2read.c 18 Aug 2006 13:25:31 -0000 @@ -3711,7 +3711,10 @@ is_vtable_name (const char *name, struct /* GCC outputs unnamed structures that are really pointers to member functions, with the ABI-specified layout. If DIE (from CU) describes such a structure, set its type, and return nonzero. Otherwise return - zero. */ + zero. + + GCC shouldn't do this; it should just output pointer to member DIEs. + This is GCC PR debug/28767. */ static int quirk_gcc_member_function_pointer (struct die_info *die, struct dwarf2_cu *cu)