From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix memory leak on bfd_close(BFD_IN_MEMORY)
Date: Tue, 08 Aug 2006 17:49:00 -0000 [thread overview]
Message-ID: <20060808174857.GB24779@nevyn.them.org> (raw)
In-Reply-To: <20060801160653.GA8511@host0.dyn.jankratochvil.net>
On Tue, Aug 01, 2006 at 06:06:53PM +0200, Jan Kratochvil wrote:
> I feel the patch
> 2004-10-24 Daniel Jacobowitz <dan@debian.org>
>
> * opncls.c (bfd_close): Return TRUE for BFD_IN_MEMORY.
>
> introduced a memory leak. This codepath occurs only on ia64 on the second run:
Well, it was already there, I think. Anyway, the master copy of BFD
belongs to the binutils project; you should send patches for it to the
binutils@ list.
I don't think your patch is quite right since bim is not always
malloc'd. It's sometimes bfd_alloc'd. Doing that more often might be
a better solution.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2006-08-08 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 16:07 Jan Kratochvil
2006-08-08 17:49 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808174857.GB24779@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox