From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21068 invoked by alias); 8 Aug 2006 17:49:02 -0000 Received: (qmail 21060 invoked by uid 22791); 8 Aug 2006 17:49:01 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 08 Aug 2006 17:49:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GAVhJ-0006Yo-Un; Tue, 08 Aug 2006 13:48:58 -0400 Date: Tue, 08 Aug 2006 17:49:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix memory leak on bfd_close(BFD_IN_MEMORY) Message-ID: <20060808174857.GB24779@nevyn.them.org> Mail-Followup-To: Jan Kratochvil , gdb-patches@sourceware.org References: <20060801160653.GA8511@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060801160653.GA8511@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00047.txt.bz2 On Tue, Aug 01, 2006 at 06:06:53PM +0200, Jan Kratochvil wrote: > I feel the patch > 2004-10-24 Daniel Jacobowitz > > * opncls.c (bfd_close): Return TRUE for BFD_IN_MEMORY. > > introduced a memory leak. This codepath occurs only on ia64 on the second run: Well, it was already there, I think. Anyway, the master copy of BFD belongs to the binutils project; you should send patches for it to the binutils@ list. I don't think your patch is quite right since bim is not always malloc'd. It's sometimes bfd_alloc'd. Doing that more often might be a better solution. -- Daniel Jacobowitz CodeSourcery