From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: drow@false.org, gdb-patches@sourceware.org
Subject: Re: [patch] Linux MAY_FOLLOW_EXEC #2 [Re: RFC: Fix crash on i386 (%gs-)threaded programs using execve(2)]
Date: Mon, 31 Jul 2006 20:39:00 -0000 [thread overview]
Message-ID: <200607312038.k6VKchKj018729@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20060729185317.GA16200@host0.dyn.jankratochvil.net> (message from Jan Kratochvil on Sat, 29 Jul 2006 20:53:17 +0200)
> Date: Sat, 29 Jul 2006 20:53:17 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> That waitpid(3) WNOHANG smells there for me but it does not hurt the
> testsuite. Should I investigate it more?
That WNOHANG is wrong; inf_ptrace_mourn_inferior() is supposed to be
called when the inferior died. We must call waitpid(2) to make sure
we don't leave behind a zombie. Unfortunately there is some sort of
race and we have to do a blocking wait at this stage, otherwise the
rotting corpse might still escape us.
Mark
next prev parent reply other threads:[~2006-07-31 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-14 10:55 RFC: Fix crash on i386 (%gs-)threaded programs using execve(2) Jan Kratochvil
2006-06-14 14:25 ` Daniel Jacobowitz
2006-06-15 20:36 ` Jan Kratochvil
2006-07-21 18:16 ` Jan Kratochvil
2006-07-21 18:44 ` Daniel Jacobowitz
2006-07-22 12:31 ` Jan Kratochvil
2006-07-24 19:03 ` Daniel Jacobowitz
2006-07-29 18:54 ` [patch] Linux MAY_FOLLOW_EXEC #2 [Re: RFC: Fix crash on i386 (%gs-)threaded programs using execve(2)] Jan Kratochvil
2006-07-31 20:39 ` Mark Kettenis [this message]
2006-08-05 16:43 ` [patch] Linux MAY_FOLLOW_EXEC #2 Jan Kratochvil
2006-08-08 16:01 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607312038.k6VKchKj018729@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox