Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Fix crash on i386 (%gs-)threaded programs using execve(2)
Date: Fri, 21 Jul 2006 18:44:00 -0000	[thread overview]
Message-ID: <20060721184421.GA22820@nevyn.them.org> (raw)
In-Reply-To: <20060721181556.GA9150@lace.redhat.com>

On Fri, Jul 21, 2006 at 08:15:57PM +0200, Jan Kratochvil wrote:
> Hi Daniel,
> 
> I am now copyright assignment compliant (as Red Hat employee).
> 
> The mail below was never replied; the patch still applies to the latest CVS.
> Could you please review it?

Turning on MAY_FOLLOW_EXEC is not a good idea.  No one really knows how
that behavior works, a lot of it doesn't, and the way it implicitly
changes the symbol file is very disorienting.  Please don't mix it up
with the fix for your current bug.

It seems to me that you need thread_db_wait to check for EXECD, and pop
the threading target off the stack when it happens.  Maybe, if you want
to be fancy, figure out the right place to push itself back on - but
that's more troublesome to get right.

unpush_target (&thread_db_ops);
using_thread_db = 0;
wipe the thread list?;
return some the underlying process pid;

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-07-21 18:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-14 10:55 Jan Kratochvil
2006-06-14 14:25 ` Daniel Jacobowitz
2006-06-15 20:36   ` Jan Kratochvil
2006-07-21 18:16     ` Jan Kratochvil
2006-07-21 18:44       ` Daniel Jacobowitz [this message]
2006-07-22 12:31         ` Jan Kratochvil
2006-07-24 19:03           ` Daniel Jacobowitz
2006-07-29 18:54             ` [patch] Linux MAY_FOLLOW_EXEC #2 [Re: RFC: Fix crash on i386 (%gs-)threaded programs using execve(2)] Jan Kratochvil
2006-07-31 20:39               ` Mark Kettenis
2006-08-05 16:43                 ` [patch] Linux MAY_FOLLOW_EXEC #2 Jan Kratochvil
2006-08-08 16:01                   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060721184421.GA22820@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox