From: Daniel Jacobowitz <drow@false.org>
To: fnf@diveadx.com
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH] Fix inconsistent usage of FRAME_OBSTACK_ZALLOC macro
Date: Mon, 24 Jul 2006 21:10:00 -0000 [thread overview]
Message-ID: <20060724211008.GA18103@nevyn.them.org> (raw)
In-Reply-To: <200607241705.37217.fnf@ninemoons.com>
On Mon, Jul 24, 2006 at 05:05:37PM -0400, Fred Fish wrote:
> Of the 50+ places that reference frame_obstack_zalloc(), about 50 of
> them use the FRAME_OBSTACK_ZALLOC macro. The rest call the function
> directly.
>
> This patch makes them all consistently use the macro.
I gather you didn't test Alpha. This patch is wrong.
> - info->saved_regs = frame_obstack_zalloc (SIZEOF_FRAME_SAVED_REGS);
> + info->saved_regs = FRAME_OBSTACK_ZALLOC (SIZEOF_FRAME_SAVED_REGS);
That will probably allocate sizeof (int).
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-24 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 21:05 Fred Fish
2006-07-24 21:10 ` Daniel Jacobowitz [this message]
2006-07-24 21:31 ` Fred Fish
2006-07-25 12:17 ` Fred Fish
2006-07-25 12:21 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724211008.GA18103@nevyn.them.org \
--to=drow@false.org \
--cc=fnf@diveadx.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox