From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5772 invoked by alias); 24 Jul 2006 21:10:12 -0000 Received: (qmail 5764 invoked by uid 22791); 24 Jul 2006 21:10:12 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 24 Jul 2006 21:10:10 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G57gm-0004iw-H4; Mon, 24 Jul 2006 17:10:08 -0400 Date: Mon, 24 Jul 2006 21:10:00 -0000 From: Daniel Jacobowitz To: fnf@diveadx.com Cc: GDB Patches Subject: Re: [PATCH] Fix inconsistent usage of FRAME_OBSTACK_ZALLOC macro Message-ID: <20060724211008.GA18103@nevyn.them.org> Mail-Followup-To: fnf@diveadx.com, GDB Patches References: <200607241705.37217.fnf@ninemoons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607241705.37217.fnf@ninemoons.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00361.txt.bz2 On Mon, Jul 24, 2006 at 05:05:37PM -0400, Fred Fish wrote: > Of the 50+ places that reference frame_obstack_zalloc(), about 50 of > them use the FRAME_OBSTACK_ZALLOC macro. The rest call the function > directly. > > This patch makes them all consistently use the macro. I gather you didn't test Alpha. This patch is wrong. > - info->saved_regs = frame_obstack_zalloc (SIZEOF_FRAME_SAVED_REGS); > + info->saved_regs = FRAME_OBSTACK_ZALLOC (SIZEOF_FRAME_SAVED_REGS); That will probably allocate sizeof (int). -- Daniel Jacobowitz CodeSourcery