From: Daniel Jacobowitz <drow@false.org>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: gdb-patches@sourceware.org
Subject: Re: GDB 6.5 RTEMS patch
Date: Mon, 24 Jul 2006 20:28:00 -0000 [thread overview]
Message-ID: <20060724202837.GE15759@nevyn.them.org> (raw)
In-Reply-To: <44B6AFEF.6050903@oarcorp.com>
On Thu, Jul 13, 2006 at 03:41:19PM -0500, Joel Sherrill wrote:
> diff -uNr /home/joel/tools-original/gdb-6.5/bfd/sysdep.h gdb-6.5/bfd/sysdep.h
> --- /home/joel/tools-original/gdb-6.5/bfd/sysdep.h 2005-05-05 13:51:14.000000000 -0500
> +++ gdb-6.5/bfd/sysdep.h 2006-07-13 10:00:00.000000000 -0500
> @@ -135,7 +135,7 @@
> #endif
>
> #if !HAVE_DECL_STRSTR
> -extern char *strstr ();
> +/* extern char *strstr (); */
> #endif
>
> #ifdef HAVE_FTELLO
What's this for? Shouldn't be necessary, of course.
> diff -uNr /home/joel/tools-original/gdb-6.5/sim/erc32/exec.c gdb-6.5/sim/erc32/exec.c
> --- /home/joel/tools-original/gdb-6.5/sim/erc32/exec.c 2005-03-07 05:09:05.000000000 -0600
> +++ gdb-6.5/sim/erc32/exec.c 2006-07-13 10:00:00.000000000 -0500
> @@ -1713,7 +1713,7 @@
> sregs->fdp[rs2 | 1] = sregs->fs[rs2 & ~1];
> sregs->fdp[rs2 & ~1] = sregs->fs[rs2 | 1];
> default:
> - ;
> + break;
> }
> #endif
>
> @@ -1886,7 +1886,7 @@
> sregs->fs[rd & ~1] = sregs->fdp[rd | 1];
> sregs->fs[rd | 1] = sregs->fdp[rd & ~1];
> default:
> - ;
> + break;
> }
> #endif
> if (sregs->fpstate == FP_EXC_PE) {
Are you sure these are still needed? I thought that "default: }" was
bad, but "default: ;}" was fine.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-24 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 20:41 Joel Sherrill
2006-07-24 20:28 ` Daniel Jacobowitz [this message]
2006-07-24 20:40 ` Joel Sherrill
2006-08-08 18:57 ` Daniel Jacobowitz
2006-08-14 15:43 ` Joel Sherrill
2006-10-09 19:11 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724202837.GE15759@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=joel.sherrill@oarcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox