From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-45126-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9309 invoked by alias); 24 Jul 2006 20:28:43 -0000
Received: (qmail 9298 invoked by uid 22791); 24 Jul 2006 20:28:41 -0000
X-Spam-Check-By: sourceware.org
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)     by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 24 Jul 2006 20:28:40 +0000
Received: from drow by nevyn.them.org with local (Exim 4.54) 	id 1G572b-0004Mb-Je; Mon, 24 Jul 2006 16:28:37 -0400
Date: Mon, 24 Jul 2006 20:28:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: gdb-patches@sourceware.org
Subject: Re: GDB 6.5 RTEMS patch
Message-ID: <20060724202837.GE15759@nevyn.them.org>
Mail-Followup-To: Joel Sherrill <joel.sherrill@oarcorp.com>, 	gdb-patches@sourceware.org
References: <44B6AFEF.6050903@oarcorp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44B6AFEF.6050903@oarcorp.com>
User-Agent: Mutt/1.5.11+cvs20060403
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-07/txt/msg00352.txt.bz2

On Thu, Jul 13, 2006 at 03:41:19PM -0500, Joel Sherrill wrote:
> diff -uNr /home/joel/tools-original/gdb-6.5/bfd/sysdep.h gdb-6.5/bfd/sysdep.h
> --- /home/joel/tools-original/gdb-6.5/bfd/sysdep.h	2005-05-05 13:51:14.000000000 -0500
> +++ gdb-6.5/bfd/sysdep.h	2006-07-13 10:00:00.000000000 -0500
> @@ -135,7 +135,7 @@
>  #endif
>  
>  #if !HAVE_DECL_STRSTR
> -extern char *strstr ();
> +/* extern char *strstr (); */
>  #endif
>  
>  #ifdef HAVE_FTELLO

What's this for?  Shouldn't be necessary, of course.

> diff -uNr /home/joel/tools-original/gdb-6.5/sim/erc32/exec.c gdb-6.5/sim/erc32/exec.c
> --- /home/joel/tools-original/gdb-6.5/sim/erc32/exec.c	2005-03-07 05:09:05.000000000 -0600
> +++ gdb-6.5/sim/erc32/exec.c	2006-07-13 10:00:00.000000000 -0500
> @@ -1713,7 +1713,7 @@
>      	    sregs->fdp[rs2 | 1] = sregs->fs[rs2 & ~1];
>      	    sregs->fdp[rs2 & ~1] = sregs->fs[rs2 | 1];
>      default:
> -      ;
> +      break;
>      }
>  #endif
>  
> @@ -1886,7 +1886,7 @@
>  	sregs->fs[rd & ~1] = sregs->fdp[rd | 1];
>  	sregs->fs[rd | 1] = sregs->fdp[rd & ~1];
>      default:
> -      ;
> +      break;
>      }
>  #endif
>      if (sregs->fpstate == FP_EXC_PE) {

Are you sure these are still needed?  I thought that "default: }" was
bad, but "default: ;}" was fine.

-- 
Daniel Jacobowitz
CodeSourcery