From: Daniel Jacobowitz <drow@false.org>
To: Roger Sayle <roger@eyesopen.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Correct irix5-nat.c's fetch_core_registers
Date: Mon, 24 Jul 2006 19:49:00 -0000 [thread overview]
Message-ID: <20060724194914.GD13612@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0607210948200.3182-100000@www.eyesopen.com>
On Fri, Jul 21, 2006 at 10:12:10AM -0600, Roger Sayle wrote:
> ! else if (mips_isa_regsize (current_gdbarch) == 4 &&
> ! core_reg_size == (2 * mips_isa_regsize (current_gdbarch)) * NUM_REGS)
> ! else /* mips_isa_regsize (current_gdbarch) == 4 */
> {
> /* This is a core file from a N32 executable, 64 bits are saved
> for all registers. */
This change doesn't make sense to me. If I'm missing something, could
you try to explain it again?
As far as I remember, Irix supports O32 executables. So at a minimum
the comment is wrong. I don't know if it dumps 32-bit or 64-bit
registers for O32 core files; I wouldn't be too surprised if it dumped
64-bit core files and just the comment needed fixing.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-07-24 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 16:41 Roger Sayle
2006-07-24 19:49 ` Daniel Jacobowitz [this message]
2006-07-24 21:34 ` Roger Sayle
2006-07-24 21:46 ` Daniel Jacobowitz
2006-07-25 16:31 ` [PATCH] Correct irix5-nat.c's fetch_core_registers (take 2) Roger Sayle
2006-07-27 21:27 ` Daniel Jacobowitz
2006-07-25 17:31 [PATCH] Correct irix5-nat.c's fetch_core_registers David Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060724194914.GD13612@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=roger@eyesopen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox