From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9109 invoked by alias); 24 Jul 2006 19:49:19 -0000 Received: (qmail 9101 invoked by uid 22791); 24 Jul 2006 19:49:19 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 24 Jul 2006 19:49:17 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G56QU-00042k-S1; Mon, 24 Jul 2006 15:49:14 -0400 Date: Mon, 24 Jul 2006 19:49:00 -0000 From: Daniel Jacobowitz To: Roger Sayle Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Correct irix5-nat.c's fetch_core_registers Message-ID: <20060724194914.GD13612@nevyn.them.org> Mail-Followup-To: Roger Sayle , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00342.txt.bz2 On Fri, Jul 21, 2006 at 10:12:10AM -0600, Roger Sayle wrote: > ! else if (mips_isa_regsize (current_gdbarch) == 4 && > ! core_reg_size == (2 * mips_isa_regsize (current_gdbarch)) * NUM_REGS) > ! else /* mips_isa_regsize (current_gdbarch) == 4 */ > { > /* This is a core file from a N32 executable, 64 bits are saved > for all registers. */ This change doesn't make sense to me. If I'm missing something, could you try to explain it again? As far as I remember, Irix supports O32 executables. So at a minimum the comment is wrong. I don't know if it dumps 32-bit or 64-bit registers for O32 core files; I wouldn't be too surprised if it dumped 64-bit core files and just the comment needed fixing. -- Daniel Jacobowitz CodeSourcery