Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/testsuite] Remove all remaining gdb_suppress_entire_file
Date: Fri, 21 Jul 2006 00:43:00 -0000	[thread overview]
Message-ID: <20060721004315.GC802@nevyn.them.org> (raw)
In-Reply-To: <20060721002619.GE1499@adacore.com>

On Thu, Jul 20, 2006 at 05:26:19PM -0700, Joel Brobecker wrote:
> Hello,
> 
> As discussed in the following message:
> 
>   http://www.sourceware.org/ml/gdb-patches/2006-06/msg00347.html
> 
> The attached patch removes all remaining instances of
> gdb_suppress_entire_file, and replaces them with a call to untested
> followed by a return.
> 
> The changes were done automatically using the following zsh command:
> 
> % for i in **/*.exp
> perl -pi -e "s#^(\\s*)gdb_suppress_entire_file .*\$#\$1untested `basename $i`\n\$1return -1#" $i

Hooray!

I'll let this sit for a little while in case anyone else has comments. 
After that I think that you should go ahead.  There are a few places
where this isn't perfect (where the compile is inside a function, for
instance), but it's still strictly better than what was there.  And I
do hate gdb_suppress_entire_file.


-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-07-21  0:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-21  0:27 Joel Brobecker
2006-07-21  0:43 ` Daniel Jacobowitz [this message]
2006-07-21 22:06 ` Mark Kettenis
2006-07-21 22:43   ` Joel Brobecker
2006-07-21 23:28   ` Daniel Jacobowitz
2006-08-08 19:00     ` Daniel Jacobowitz
2006-08-08 20:10       ` Mark Kettenis
2006-08-08 20:24         ` Daniel Jacobowitz
2006-08-09 18:05           ` Joel Brobecker
2006-08-10  4:13             ` Daniel Jacobowitz
2006-08-10  0:35               ` Daniel Jacobowitz
2006-08-10 14:12               ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060721004315.GC802@nevyn.them.org \
    --to=drow@false.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox