From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14141 invoked by alias); 21 Jul 2006 00:43:19 -0000 Received: (qmail 14131 invoked by uid 22791); 21 Jul 2006 00:43:19 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 21 Jul 2006 00:43:18 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1G3j6p-0000FP-Us; Thu, 20 Jul 2006 20:43:16 -0400 Date: Fri, 21 Jul 2006 00:43:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/testsuite] Remove all remaining gdb_suppress_entire_file Message-ID: <20060721004315.GC802@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20060721002619.GE1499@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060721002619.GE1499@adacore.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-07/txt/msg00284.txt.bz2 On Thu, Jul 20, 2006 at 05:26:19PM -0700, Joel Brobecker wrote: > Hello, > > As discussed in the following message: > > http://www.sourceware.org/ml/gdb-patches/2006-06/msg00347.html > > The attached patch removes all remaining instances of > gdb_suppress_entire_file, and replaces them with a call to untested > followed by a return. > > The changes were done automatically using the following zsh command: > > % for i in **/*.exp > perl -pi -e "s#^(\\s*)gdb_suppress_entire_file .*\$#\$1untested `basename $i`\n\$1return -1#" $i Hooray! I'll let this sit for a little while in case anyone else has comments. After that I think that you should go ahead. There are a few places where this isn't perfect (where the compile is inside a function, for instance), but it's still strictly better than what was there. And I do hate gdb_suppress_entire_file. -- Daniel Jacobowitz CodeSourcery