[PATCH] Don't include private kernel header building powerpc-elf sim

[PATCH] Don't include private kernel header building powerpc-elf sim

[Fred Fish]

When building powerpc-eabi gdb on Fedora Core 5 I'm getting a bunch
of warnings of the form:

  In file included from /src/latest/patched/src/gdb/sim/ppc/sim-endian.h:97,
                 from /src/latest/patched/src/gdb/sim/ppc/basics.h:137,
                 from /src/latest/patched/src/gdb/sim/ppc/psim.h:25,
                 from /src/latest/patched/src/gdb/sim/ppc/gdb-sim.c:22:
  /usr/include/asm/byteorder.h:6:2: warning: #warning using private kernel header; include <endian.h> instead!

apparently due to the following line in asm/byteorder.h:

  #warning using private kernel header; include <endian.h> instead!

Removing the inclusion gets rid of the warning with no apparent ill
effects in either compiling or running the gdb testsuite.

Index: gdb/sim/ppc/ChangeLog
===================================================================
RCS file: /cvsroots/latest/src/gdb/sim/ppc/ChangeLog,v
retrieving revision 1.1.1.6.2.2
diff -c -p -r1.1.1.6.2.2 ChangeLog
*** gdb/sim/ppc/ChangeLog	14 Jun 2006 13:59:20 -0000	1.1.1.6.2.2
--- gdb/sim/ppc/ChangeLog	20 Jun 2006 20:53:52 -0000
***************
*** 1,3 ****
--- 1,8 ----
+ 2006-06-20  Fred Fish  <fnf@specifix.com>
+ 
+ 	* sim-endian.h (asm/byteorder.h): Don't include private kernel
+ 	header.
+ 
  2006-06-13  Richard Earnshaw  <rearnsha@arm.com>
  
  	* configure: Regenerated.
Index: gdb/sim/ppc/sim-endian.h
===================================================================
RCS file: /cvsroots/latest/src/gdb/sim/ppc/sim-endian.h,v
retrieving revision 1.1.1.1
diff -c -p -r1.1.1.1 sim-endian.h
*** gdb/sim/ppc/sim-endian.h	8 Oct 2005 19:36:31 -0000	1.1.1.1
--- gdb/sim/ppc/sim-endian.h	20 Jun 2006 20:58:40 -0000
*************** INLINE_PSIM_ENDIAN(unsigned_8) endian_le
*** 94,100 ****
  
  #if defined(__linux__)
  # include <endian.h>
- # include <asm/byteorder.h>
  # if defined(__LITTLE_ENDIAN) && !defined(LITTLE_ENDIAN)
  #  define LITTLE_ENDIAN __LITTLE_ENDIAN
  # endif
--- 94,99 ----

Re: [PATCH] Don't include private kernel header building powerpc-elf sim

[Daniel Jacobowitz]

On Tue, Jun 20, 2006 at 05:52:34PM -0400, Fred Fish wrote:
> + 2006-06-20  Fred Fish  <fnf@specifix.com>
> + 
> + 	* sim-endian.h (asm/byteorder.h): Don't include private kernel
> + 	header.
> + 

Sorry for the delay; this patch is fine to commit.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [PATCH] Don't include private kernel header building powerpc-elf sim

[Fred Fish]

On Wednesday 12 July 2006 17:19, Daniel Jacobowitz wrote:
> Sorry for the delay; this patch is fine to commit.

OK, thanks.  Committed.

-Fred