From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ghost@cs.msu.su
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Cleanup target memory reading
Date: Wed, 28 Jun 2006 21:30:00 -0000 [thread overview]
Message-ID: <200606282130.k5SLUbwK011892@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <200606281155.59166.ghost@cs.msu.su> (message from Vladimir Prus on Wed, 28 Jun 2006 11:55:57 +0400)
> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Wed, 28 Jun 2006 11:55:57 +0400
>
> Hi,
> at the moment, pretty much every read of target memory goes via
> target_read_memory, and then via xfer_using_stratum.
>
> The only exception is the get_target_memory_unsigned function, which calls
> target_read function. It's the only use of 'target_read'.
>
> The attached patch removes target_read, and makes get_target_memory_unsigned
> use target_read_memory.
>
> OK?
Shouldn't we "fix" target_read() such that it uses
target_read_partial() instead?
next prev parent reply other threads:[~2006-06-28 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 7:56 Vladimir Prus
2006-06-28 21:30 ` Mark Kettenis [this message]
2006-06-29 2:42 ` Daniel Jacobowitz
2006-06-29 9:34 ` Vladimir Prus
2006-07-12 19:22 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606282130.k5SLUbwK011892@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox