From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-44756-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14706 invoked by alias); 28 Jun 2006 21:30:57 -0000
Received: (qmail 14698 invoked by uid 22791); 28 Jun 2006 21:30:57 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 28 Jun 2006 21:30:54 +0000
Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) 	by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k5SLUfXJ026760; 	Wed, 28 Jun 2006 23:30:41 +0200 (CEST)
Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k5SLUbPJ031467; 	Wed, 28 Jun 2006 23:30:37 +0200 (CEST)
Received: (from kettenis@localhost) 	by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k5SLUbwK011892; 	Wed, 28 Jun 2006 23:30:37 +0200 (CEST)
Date: Wed, 28 Jun 2006 21:30:00 -0000
Message-Id: <200606282130.k5SLUbwK011892@elgar.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: ghost@cs.msu.su
CC: gdb-patches@sources.redhat.com
In-reply-to: <200606281155.59166.ghost@cs.msu.su> (message from Vladimir Prus 	on Wed, 28 Jun 2006 11:55:57 +0400)
Subject: Re: [PATCH] Cleanup target memory reading
References:  <200606281155.59166.ghost@cs.msu.su>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00393.txt.bz2

> From: Vladimir Prus <ghost@cs.msu.su>
> Date: Wed, 28 Jun 2006 11:55:57 +0400
> 
> Hi,
> at the moment, pretty much every read of target memory goes via 
> target_read_memory, and then via xfer_using_stratum.
> 
> The only exception is the get_target_memory_unsigned function, which calls 
> target_read function. It's the only use of 'target_read'.
> 
> The attached patch removes target_read, and makes get_target_memory_unsigned 
> use target_read_memory.
> 
> OK?

Shouldn't we "fix" target_read() such that it uses
target_read_partial() instead?