Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <lace@jankratochvil.net>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Fixed occasional failure to load a custom shared  library
Date: Tue, 27 Jun 2006 02:08:00 -0000	[thread overview]
Message-ID: <20060627020830.GA10712@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20060626180051.0adcce23@ironwood.lan>

Hi Kevin,

On Tue, 27 Jun 2006 03:00:51 +0200, Kevin Buettner wrote:
...
> +  solib_absolute_prefix_is_empty = (!solib_absolute_prefix
> +                                    || !*solib_absolute_prefix);
> 
> I'd prefer to see this written as follows:
> 
> +  solib_absolute_prefix_is_empty = (solib_absolute_prefix == NULL
> +                                    || *solib_absolute_prefix == 0);

OK, I tried to copy the style but apparently not perfectly.

...
> (You forgot to include a ChangeLog entry though...)

2006-06-22  Jan Kratochvil  <lace@jankratochvil.net>

	* solib.c (solib_open): Fixed NULL vs. "" refusal to load inferior
	shared libraries.


> Are you able to commit this yourself or do you need someone to commit
> it for you?

I do not have the commit rights, please commit it for me.
So far I do not have FSF copyright assignment for gdb, if it would be required
for this trivia patch.



Thanks,
Jan


  reply	other threads:[~2006-06-27  2:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 11:40 Jan Kratochvil
2006-06-27  1:01 ` Kevin Buettner
2006-06-27  2:08   ` Jan Kratochvil [this message]
2006-07-21 18:38   ` Jan Kratochvil
2006-10-09 20:17     ` Daniel Jacobowitz
2006-10-09 22:51       ` Jan Kratochvil
2006-10-10  0:00         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060627020830.GA10712@host0.dyn.jankratochvil.net \
    --to=lace@jankratochvil.net \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox