From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4349 invoked by alias); 27 Jun 2006 02:08:57 -0000 Received: (qmail 4339 invoked by uid 22791); 27 Jun 2006 02:08:55 -0000 X-Spam-Check-By: sourceware.org Received: from ip-85-160-5-109.eurotel.cz (HELO host0.dyn.jankratochvil.net) (85.160.5.109) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Jun 2006 02:08:49 +0000 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.13.6/8.13.4) with ESMTP id k5R28WPc012266; Tue, 27 Jun 2006 04:08:33 +0200 Received: (from lace@localhost) by host0.dyn.jankratochvil.net (8.13.6/8.13.6/Submit) id k5R28Uh1012265; Tue, 27 Jun 2006 04:08:30 +0200 Date: Tue, 27 Jun 2006 02:08:00 -0000 From: Jan Kratochvil To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Fixed occasional failure to load a custom shared library Message-ID: <20060627020830.GA10712@host0.dyn.jankratochvil.net> References: <20060622114016.GA21094@host0.dyn.jankratochvil.net> <20060626180051.0adcce23@ironwood.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060626180051.0adcce23@ironwood.lan> User-Agent: Mutt/1.4.2.1i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00384.txt.bz2 Hi Kevin, On Tue, 27 Jun 2006 03:00:51 +0200, Kevin Buettner wrote: ... > + solib_absolute_prefix_is_empty = (!solib_absolute_prefix > + || !*solib_absolute_prefix); > > I'd prefer to see this written as follows: > > + solib_absolute_prefix_is_empty = (solib_absolute_prefix == NULL > + || *solib_absolute_prefix == 0); OK, I tried to copy the style but apparently not perfectly. ... > (You forgot to include a ChangeLog entry though...) 2006-06-22 Jan Kratochvil * solib.c (solib_open): Fixed NULL vs. "" refusal to load inferior shared libraries. > Are you able to commit this yourself or do you need someone to commit > it for you? I do not have the commit rights, please commit it for me. So far I do not have FSF copyright assignment for gdb, if it would be required for this trivia patch. Thanks, Jan