* [ob] Remove a dejagnu ERROR from auxv.exp
@ 2006-06-22 19:35 Daniel Jacobowitz
2006-06-22 20:46 ` Mark Kettenis
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Jacobowitz @ 2006-06-22 19:35 UTC (permalink / raw)
To: gdb-patches
If your target does not support gcore at all, then it will currently
generate an ERROR running auxv.exp. This turns it into an UNSUPPORTED,
as was probably intended.
We have some nightly build machinery here at CodeSourcery which can
automatically run DejaGNU testsuites. It normally shows us nice pleasant
deltas between runs, but it's set to always include ERRORs, since they're
supposed to indicate a problem in the testsuite rather than in the tool
being tested.
Tested on x86_64-pc-linux-gnu and committed.
--
Daniel Jacobowitz
CodeSourcery
2006-06-22 Daniel Jacobowitz <dan@codesourcery.com>
* auxv.exp: Intercept undefined command messages before
gdb_test_multiple does.
Index: gdb-20060226/gdb/testsuite/gdb.base/auxv.exp
===================================================================
--- gdb-20060226.orig/gdb/testsuite/gdb.base/auxv.exp 2006-06-13 21:06:57.000000000 -0700
+++ gdb-20060226/gdb/testsuite/gdb.base/auxv.exp 2006-06-13 21:07:09.000000000 -0700
@@ -139,6 +139,9 @@ gdb_test_multiple "gcore $gcorefile" "gc
-re "Can't create a corefile\[\r\n\]+$gdb_prompt $" {
unsupported "gcore"
}
+ -re "Undefined command: .*\[\r\n\]+$gdb_prompt $" {
+ unsupported "gcore"
+ }
}
# Let the program continue and die.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [ob] Remove a dejagnu ERROR from auxv.exp
2006-06-22 19:35 [ob] Remove a dejagnu ERROR from auxv.exp Daniel Jacobowitz
@ 2006-06-22 20:46 ` Mark Kettenis
0 siblings, 0 replies; 2+ messages in thread
From: Mark Kettenis @ 2006-06-22 20:46 UTC (permalink / raw)
To: drow; +Cc: gdb-patches
> Date: Thu, 22 Jun 2006 15:35:07 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> If your target does not support gcore at all, then it will currently
> generate an ERROR running auxv.exp. This turns it into an UNSUPPORTED,
> as was probably intended.
Heh, thanks. I've been wondering how to fix this properly before, but
decided the easiest way to solve this was to implement gcore on
OpenBSD. Unfortunately that turned out to be difficult enough that I
didn't manage to do it yet.
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-22 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-22 19:35 [ob] Remove a dejagnu ERROR from auxv.exp Daniel Jacobowitz
2006-06-22 20:46 ` Mark Kettenis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox