Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI Doco
Date: Tue, 13 Jun 2006 04:46:00 -0000	[thread overview]
Message-ID: <20060613044551.030C51D3550@kahikatea.snap.net.nz> (raw)
In-Reply-To: <uu06p4tcq.fsf@gnu.org>

 > > Just one part of the second patch (GDB/MI Compatibility with CLI) was
 > > part of the previous patch.  Are you clear about/OK with this part?:
 > > 
 > > 	(GDB/MI Data Manipulation): Remove description of unimplemented
 > > 	display related commands as variable objects perform this function
 > > 	and are superior: -display-delete, -display-disable,
 > > 	-display-enable, -display-insert and -display-list.  Move
 > > 	-environment-cd, -environment-directory, -environment-path
 > > 	and -environment-pwd to "Program Context".
 > 
 > Please don't do things like that: please don't mix a corrected patch
 > with another as yet unseen patch, especially not in such large
 > patches.  I checked a few changes, saw that you fixed my comments, and
 > didn't look farther.  I cannot afford reading such large patches
 > several times; I usually trust people that when they say they took
 > care of my comments, they really did.

As you had given (conditiomal) approval for the first patch, I thought it
would be safe to send a second.  Anyway I see now that I shouldn't have
confused the issue.  For some changes, like the one above, I think you
could just look at the ChangeLog entry.

 > Now please post only the new parts, the ones I've never seen.  Please
 > don't commit anything before that.

I'm not sure where this is leading because at some stage I will want to commit
the parts that you have already seen and approved.  It would be easier for me
to commit those now and submit a patch for the new parts, so that there is no
more confusion about what you are approving.  Would that be OK?

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2006-06-13  4:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-02  0:23 Nick Roberts
2006-06-02  9:05 ` Eli Zaretskii
2006-06-02 10:23   ` Nick Roberts
2006-06-02 10:44     ` Eli Zaretskii
2006-06-03 23:57       ` Nick Roberts
2006-06-04 19:32         ` Eli Zaretskii
2006-06-09 19:07         ` Eli Zaretskii
2006-06-09 19:12           ` Daniel Jacobowitz
2006-06-09 19:52             ` Eli Zaretskii
2006-06-09 19:57               ` Daniel Jacobowitz
2006-06-10  7:32                 ` Eli Zaretskii
2006-07-01 12:35                   ` [commit] Fix MI prompt in manual (was: MI Doco) Eli Zaretskii
2006-06-09 19:58               ` [PATCH] MI Doco Bob Rossi
2006-06-09 23:27           ` Nick Roberts
2006-06-10  7:51             ` Eli Zaretskii
2006-06-10 21:40               ` Nick Roberts
2006-06-11  3:31                 ` Eli Zaretskii
2006-06-11 10:47                   ` Nick Roberts
2006-06-11 19:27                     ` Eli Zaretskii
2006-06-11 21:42                       ` Nick Roberts
2006-06-12  3:36                         ` Eli Zaretskii
2006-06-12  6:19                           ` Nick Roberts
2006-06-13  3:39                             ` Eli Zaretskii
2006-06-13  4:46                               ` Nick Roberts [this message]
2006-06-13 17:26                                 ` Eli Zaretskii
2006-06-13 21:15                                   ` Nick Roberts
2006-06-14 18:30                                     ` Eli Zaretskii
2006-06-14 21:05                                       ` Nick Roberts
2006-06-15  6:56                                         ` Eli Zaretskii
2006-06-30  2:13                                           ` Nick Roberts
2006-06-30 12:09                                             ` Eli Zaretskii
2006-06-30 14:12                                               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060613044551.030C51D3550@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox