From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8820 invoked by alias); 13 Jun 2006 04:46:49 -0000 Received: (qmail 8677 invoked by uid 22791); 13 Jun 2006 04:46:46 -0000 X-Spam-Check-By: sourceware.org Received: from viper.snap.net.nz (HELO viper.snap.net.nz) (202.37.101.8) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Jun 2006 04:46:43 +0000 Received: from kahikatea.snap.net.nz (p484-tnt1.snap.net.nz [202.124.111.230]) by viper.snap.net.nz (Postfix) with ESMTP id ECCBF76BD2F; Tue, 13 Jun 2006 16:46:41 +1200 (NZST) Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 030C51D3550; Tue, 13 Jun 2006 16:45:50 +1200 (NZST) From: Nick Roberts To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI Doco In-Reply-To: References: <17535.33986.598009.914783@kahikatea.snap.net.nz> <17536.4472.263731.425097@kahikatea.snap.net.nz> <17538.8607.697546.427486@kahikatea.snap.net.nz> <17546.915.125070.943811@kahikatea.snap.net.nz> <17547.15381.217912.425365@kahikatea.snap.net.nz> <17547.60705.62123.543072@kahikatea.snap.net.nz> <17548.36381.999594.50258@kahikatea.snap.net.nz> <17549.1830.40223.127804@kahikatea.snap.net.nz> X-Mailer: VM 7.19 under Emacs 22.0.50.20 Message-Id: <20060613044551.030C51D3550@kahikatea.snap.net.nz> Date: Tue, 13 Jun 2006 04:46:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00166.txt.bz2 > > Just one part of the second patch (GDB/MI Compatibility with CLI) was > > part of the previous patch. Are you clear about/OK with this part?: > > > > (GDB/MI Data Manipulation): Remove description of unimplemented > > display related commands as variable objects perform this function > > and are superior: -display-delete, -display-disable, > > -display-enable, -display-insert and -display-list. Move > > -environment-cd, -environment-directory, -environment-path > > and -environment-pwd to "Program Context". > > Please don't do things like that: please don't mix a corrected patch > with another as yet unseen patch, especially not in such large > patches. I checked a few changes, saw that you fixed my comments, and > didn't look farther. I cannot afford reading such large patches > several times; I usually trust people that when they say they took > care of my comments, they really did. As you had given (conditiomal) approval for the first patch, I thought it would be safe to send a second. Anyway I see now that I shouldn't have confused the issue. For some changes, like the one above, I think you could just look at the ChangeLog entry. > Now please post only the new parts, the ones I've never seen. Please > don't commit anything before that. I'm not sure where this is leading because at some stage I will want to commit the parts that you have already seen and approved. It would be easier for me to commit those now and submit a patch for the new parts, so that there is no more confusion about what you are approving. Would that be OK? -- Nick http://www.inet.net.nz/~nickrob