Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>,
		Fred Fish <fnf@specifix.com>
Subject: Re: [RFA] replace stub fn mips_eabi_return_value
Date: Fri, 09 Jun 2006 18:41:00 -0000	[thread overview]
Message-ID: <20060609184026.GC860@adacore.com> (raw)
In-Reply-To: <447E2CF3.4070102@redhat.com>

> 2006-05-31  Michael Snyder  <msnyder@redhat.com>
> 
> 	* mips-tdep.c (mips_eabi_return_value): Replace stub that always
> 	returned RETURN_VALUE_STRUCT_CONVENTION with a real function.

This looks OK to me. Just make sure to remove the two commented out
lines of code in the last "for" block.

Thanks.

> !   for (offset = 0;
> !        offset < TYPE_LENGTH (type);
> !        /* offset += register_size (gdbarch, regnum), regnum++) */
> !        offset += mips_stack_argsize (gdbarch), regnum++)
> !     {
> !       /* xfer = register_size (gdbarch, regnum); */

-- 
Joel


  parent reply	other threads:[~2006-06-09 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <447E2CF3.4070102@redhat.com>
2006-06-08 19:17 ` Michael Snyder
2006-06-09 18:41 ` Joel Brobecker [this message]
2006-06-12 19:26   ` Michael Snyder
2006-06-12 20:08     ` Fred Fish
2006-06-12 20:59     ` Fred Fish
2006-06-21 11:37 ` Fred Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060609184026.GC860@adacore.com \
    --to=brobecker@adacore.com \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox