From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-44466-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1080 invoked by alias); 9 Jun 2006 18:41:27 -0000
Received: (qmail 1072 invoked by uid 22791); 9 Jun 2006 18:41:26 -0000
X-Spam-Check-By: sourceware.org
Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Jun 2006 18:40:29 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-nile.gnat.com (Postfix) with ESMTP id B18CB48CE3E; 	Fri,  9 Jun 2006 14:40:27 -0400 (EDT)
Received: from nile.gnat.com ([127.0.0.1])  by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP  id 07318-01-7; Fri,  9 Jun 2006 14:40:27 -0400 (EDT)
Received: from takamaka.act-europe.fr (s142-179-108-108.bc.hsia.telus.net [142.179.108.108]) 	by nile.gnat.com (Postfix) with ESMTP id 3646848CBF9; 	Fri,  9 Jun 2006 14:40:27 -0400 (EDT)
Received: by takamaka.act-europe.fr (Postfix, from userid 507) 	id 5C83D47E7F; Fri,  9 Jun 2006 11:40:26 -0700 (PDT)
Date: Fri, 09 Jun 2006 18:41:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>, 	Fred Fish <fnf@specifix.com>
Subject: Re: [RFA] replace stub fn mips_eabi_return_value
Message-ID: <20060609184026.GC860@adacore.com>
References: <447E2CF3.4070102@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <447E2CF3.4070102@redhat.com>
User-Agent: Mutt/1.4i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-06/txt/msg00103.txt.bz2

> 2006-05-31  Michael Snyder  <msnyder@redhat.com>
> 
> 	* mips-tdep.c (mips_eabi_return_value): Replace stub that always
> 	returned RETURN_VALUE_STRUCT_CONVENTION with a real function.

This looks OK to me. Just make sure to remove the two commented out
lines of code in the last "for" block.

Thanks.

> !   for (offset = 0;
> !        offset < TYPE_LENGTH (type);
> !        /* offset += register_size (gdbarch, regnum), regnum++) */
> !        offset += mips_stack_argsize (gdbarch), regnum++)
> !     {
> !       /* xfer = register_size (gdbarch, regnum); */

-- 
Joel