Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nathan Sidwell <nathan@codesourcery.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: patch for invalid hw breakpoints
Date: Thu, 01 Jun 2006 18:03:00 -0000	[thread overview]
Message-ID: <20060601180321.GA26791@nevyn.them.org> (raw)
In-Reply-To: <447F27BC.6030808@codesourcery.com>

On Thu, Jun 01, 2006 at 06:45:32PM +0100, Nathan Sidwell wrote:
> The remote stub can deal with this, but the functionality detection code in 
> remote.c cannot.  In particular this bit of code in 
> remote_remove_watchpoint triggers because the just attempted 
> remote_insert_watchpoint call has now set the support field to 
> PACKET_DISABLE.

Oh.  So, more like this:

-> Z2,11110000
<- [empty: I don't support that.]
tries to send: -> z2,11110000
[internal error, I already know I don't support that!]

That could be changed in remote.c, but not removing what we didn't
insert does seem cleaner.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-06-01 18:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <447EE9A8.4050800@codesourcery.com>
2006-06-01 17:21 ` Eli Zaretskii
2006-06-01 17:26   ` Daniel Jacobowitz
2006-06-01 17:46     ` Nathan Sidwell
2006-06-01 18:03       ` Daniel Jacobowitz [this message]
2006-06-01 20:53         ` Eli Zaretskii
2006-06-01 21:12           ` Daniel Jacobowitz
2006-06-02  8:44             ` Eli Zaretskii
2006-06-02 13:52               ` Daniel Jacobowitz
2006-06-02 20:56                 ` Eli Zaretskii
2006-06-02 20:57                   ` Daniel Jacobowitz
2006-06-05 14:30               ` Nathan Sidwell
2006-06-05 19:58                 ` Eli Zaretskii
2006-06-02  7:26         ` Nathan Sidwell
2006-06-02  8:13           ` Eli Zaretskii
2006-06-01 18:33       ` Nathan Sidwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060601180321.GA26791@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nathan@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox