From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23615 invoked by alias); 1 Jun 2006 18:03:26 -0000 Received: (qmail 23607 invoked by uid 22791); 1 Jun 2006 18:03:26 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 01 Jun 2006 18:03:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FlrVx-0006yk-Dn; Thu, 01 Jun 2006 14:03:21 -0400 Date: Thu, 01 Jun 2006 18:03:00 -0000 From: Daniel Jacobowitz To: Nathan Sidwell Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: patch for invalid hw breakpoints Message-ID: <20060601180321.GA26791@nevyn.them.org> Mail-Followup-To: Nathan Sidwell , Eli Zaretskii , gdb-patches@sourceware.org References: <447EE9A8.4050800@codesourcery.com> <20060601172639.GA25709@nevyn.them.org> <447F27BC.6030808@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <447F27BC.6030808@codesourcery.com> User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00006.txt.bz2 On Thu, Jun 01, 2006 at 06:45:32PM +0100, Nathan Sidwell wrote: > The remote stub can deal with this, but the functionality detection code in > remote.c cannot. In particular this bit of code in > remote_remove_watchpoint triggers because the just attempted > remote_insert_watchpoint call has now set the support field to > PACKET_DISABLE. Oh. So, more like this: -> Z2,11110000 <- [empty: I don't support that.] tries to send: -> z2,11110000 [internal error, I already know I don't support that!] That could be changed in remote.c, but not removing what we didn't insert does seem cleaner. -- Daniel Jacobowitz CodeSourcery