* Re: gdb/m2-typeprint.c does not compile with older gcc versions
[not found] <200605271112.k4RBCSts022936@licht.localdomain>
@ 2006-05-28 5:58 ` Joel Brobecker
2006-05-29 12:28 ` Jim Blandy
0 siblings, 1 reply; 2+ messages in thread
From: Joel Brobecker @ 2006-05-28 5:58 UTC (permalink / raw)
To: Peter Schauer; +Cc: gdb, gdb-patches
On Sat, May 27, 2006 at 01:12:28PM +0200, Peter Schauer wrote:
> gdb/m2-typeprint.c does not compile with older gcc versions, e.g. gcc-2.95.2.
> It is caused by declarations after code, which is a gcc extension AFAIK.
> The gdb-6.5 branch is affected as well.
> Here is a fix:
Thanks Peter. To me, this is an obvious fix, so I checked it in for you
in both head and 6.5 branch.
2006-05-27 Joel Brobecker <brobecker@adacore.com>
From Peter Schauer <peterschauer@gmx.net>
* m2-typeprint.c (m2_record_fields): Move variable declarations
to the begining of the block.
Tested by re-building GDB after patch.
--
Joel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gdb/m2-typeprint.c does not compile with older gcc versions
2006-05-28 5:58 ` gdb/m2-typeprint.c does not compile with older gcc versions Joel Brobecker
@ 2006-05-29 12:28 ` Jim Blandy
0 siblings, 0 replies; 2+ messages in thread
From: Jim Blandy @ 2006-05-29 12:28 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Peter Schauer, gdb, gdb-patches
Joel Brobecker <brobecker@adacore.com> writes:
> On Sat, May 27, 2006 at 01:12:28PM +0200, Peter Schauer wrote:
>> gdb/m2-typeprint.c does not compile with older gcc versions, e.g. gcc-2.95.2.
>> It is caused by declarations after code, which is a gcc extension AFAIK.
>> The gdb-6.5 branch is affected as well.
>> Here is a fix:
>
> Thanks Peter. To me, this is an obvious fix, so I checked it in for you
> in both head and 6.5 branch.
>
> 2006-05-27 Joel Brobecker <brobecker@adacore.com>
>
> From Peter Schauer <peterschauer@gmx.net>
> * m2-typeprint.c (m2_record_fields): Move variable declarations
> to the begining of the block.
>
> Tested by re-building GDB after patch.
For what it's worth, ISO C99 allows declarations after code. I don't
know when it was introduced. GDB is supposed to only require C90,
according to doc/gdbint.texinfo, so I agree the patch is right,
though.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-28 22:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200605271112.k4RBCSts022936@licht.localdomain>
2006-05-28 5:58 ` gdb/m2-typeprint.c does not compile with older gcc versions Joel Brobecker
2006-05-29 12:28 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox