Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH: Morpho Technologies register patch
@ 2006-04-29  1:20 Mark Mitchell
  2006-05-23  4:54 ` Kevin Buettner
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Mitchell @ 2006-04-29  1:20 UTC (permalink / raw)
  To: gdb-patches; +Cc: kevinb


I noticed that in MI mode, which the Morpho patches previously posted,
I wasn't seeing all of the registers with -data-list-register-names.
The problem was that we had hard-coded the last register number into
mt_register_name; this change updates that to use the enumeral that
actually corresponds to the last register number, rather than just
using the register that happens to be last.

I've now got three patches outstanding:

http://sources.redhat.com/ml/gdb-patches/2006-04/msg00141.html

http://sources.redhat.com/ml/gdb-patches/2006-04/msg00251.html

and this one.

Kevin, I see that you're listed as the maintainer for this port, so
I've CC'd you on this mail, in the hopes that you might have a spare
minute to look at the patches.

Thanks,

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713

2006-04-28  Mark Mitchell  <mark@codesourcery.com>

	* gdb/mt-tdep.c (mt_register_name): Correct out-of-range logic to
	include additional registers. 

Index: gdb/mt-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mt-tdep.c,v
retrieving revision 1.4.2.2
diff -c -5 -p -r1.4.2.2 mt-tdep.c
*** gdb/mt-tdep.c	19 Apr 2006 04:53:13 -0000	1.4.2.2
--- gdb/mt-tdep.c	29 Apr 2006 00:34:08 -0000
*************** mt_register_name (int regnum)
*** 183,193 ****
      dim_1 = ((regnum / MT_COPRO_PSEUDOREG_REGS / MT_COPRO_PSEUDOREG_DIM_2)
  	     %  MT_COPRO_PSEUDOREG_DIM_1);
      
      if (index == MT_COPRO_PSEUDOREG_MAC_REGNUM)
        stub = register_names[MT_MAC_PSEUDOREG_REGNUM];
!     else if (index > MT_QCHANNEL_REGNUM - MT_CPR0_REGNUM)
        stub = "";
      else
        stub = register_names[index + MT_CPR0_REGNUM];
      if (!*stub)
        {
--- 183,193 ----
      dim_1 = ((regnum / MT_COPRO_PSEUDOREG_REGS / MT_COPRO_PSEUDOREG_DIM_2)
  	     %  MT_COPRO_PSEUDOREG_DIM_1);
      
      if (index == MT_COPRO_PSEUDOREG_MAC_REGNUM)
        stub = register_names[MT_MAC_PSEUDOREG_REGNUM];
!     else if (index >= MT_NUM_REGS - MT_CPR0_REGNUM)
        stub = "";
      else
        stub = register_names[index + MT_CPR0_REGNUM];
      if (!*stub)
        {


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: Morpho Technologies register patch
  2006-04-29  1:20 PATCH: Morpho Technologies register patch Mark Mitchell
@ 2006-05-23  4:54 ` Kevin Buettner
  2006-05-23 19:24   ` Mark Mitchell
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2006-05-23  4:54 UTC (permalink / raw)
  To: mark; +Cc: gdb-patches

On Fri, 28 Apr 2006 18:19:58 -0700
Mark Mitchell <mark@codesourcery.com> wrote:

> I've now got three patches outstanding:
> 
> http://sources.redhat.com/ml/gdb-patches/2006-04/msg00141.html

I've just okayed this one.

> http://sources.redhat.com/ml/gdb-patches/2006-04/msg00251.html

This one I okayed a while back.  Sorry for missing that earlier one.

> and this one.
> 
> 2006-04-28  Mark Mitchell  <mark@codesourcery.com>
> 
> 	* gdb/mt-tdep.c (mt_register_name): Correct out-of-range logic to
> 	include additional registers. 

This is okay too.  (I.e., all three of the mt patches are approved.)

Kevin


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: PATCH: Morpho Technologies register patch
  2006-05-23  4:54 ` Kevin Buettner
@ 2006-05-23 19:24   ` Mark Mitchell
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Mitchell @ 2006-05-23 19:24 UTC (permalink / raw)
  To: Kevin Buettner; +Cc: gdb-patches

Kevin Buettner wrote:

> This is okay too.  (I.e., all three of the mt patches are approved.)

Committed, thanks!

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-05-23 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-04-29  1:20 PATCH: Morpho Technologies register patch Mark Mitchell
2006-05-23  4:54 ` Kevin Buettner
2006-05-23 19:24   ` Mark Mitchell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox