From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] New target, Renesas M32C
Date: Thu, 20 Apr 2006 16:33:00 -0000 [thread overview]
Message-ID: <20060420163311.GH11710@nevyn.them.org> (raw)
In-Reply-To: <443EBDFB.7090601@redhat.com>
On Thu, Apr 13, 2006 at 02:09:15PM -0700, Michael Snyder wrote:
> This target architecture has already been added to gcc and binutils.
> Here's the gdb port.
I think this is fine. I only skimmed it; the most interesting bits are
the prologue analysis, which I've looked over before. The rest nothing
jumped out at me. Other than that I've only very small comments:
- Please add it to NEWS as Eli requested.
- Are you volunteering to maintain this port? If so, please add
a MAINTAINERS entry. If not, I don't want a port added without
a maintainer.
- Instead of this:
> + #if defined (HAVE_STRING_H)
> + #include <string.h>
> + #endif
use "gdb_string.h".
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-20 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-13 21:09 Michael Snyder
2006-04-13 21:57 ` Jim Blandy
2006-04-14 8:04 ` Eli Zaretskii
2006-04-20 16:33 ` Daniel Jacobowitz [this message]
2006-04-20 19:09 ` Michael Snyder
2006-04-20 21:56 ` Jim Blandy
2006-04-20 23:23 ` Michael Snyder
2006-04-21 7:35 ` Eli Zaretskii
2006-04-24 20:57 ` Daniel Jacobowitz
2006-04-24 22:46 ` Michael Snyder
2006-04-24 22:53 ` Jim Blandy
2006-04-25 0:19 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060420163311.GH11710@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox