From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22109 invoked by alias); 20 Apr 2006 16:33:16 -0000 Received: (qmail 22082 invoked by uid 22791); 20 Apr 2006 16:33:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 20 Apr 2006 16:33:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FWc5f-0004in-PK; Thu, 20 Apr 2006 12:33:11 -0400 Date: Thu, 20 Apr 2006 16:33:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: [RFC] New target, Renesas M32C Message-ID: <20060420163311.GH11710@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sourceware.org References: <443EBDFB.7090601@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <443EBDFB.7090601@redhat.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00279.txt.bz2 On Thu, Apr 13, 2006 at 02:09:15PM -0700, Michael Snyder wrote: > This target architecture has already been added to gcc and binutils. > Here's the gdb port. I think this is fine. I only skimmed it; the most interesting bits are the prologue analysis, which I've looked over before. The rest nothing jumped out at me. Other than that I've only very small comments: - Please add it to NEWS as Eli requested. - Are you volunteering to maintain this port? If so, please add a MAINTAINERS entry. If not, I don't want a port added without a maintainer. - Instead of this: > + #if defined (HAVE_STRING_H) > + #include > + #endif use "gdb_string.h". -- Daniel Jacobowitz CodeSourcery