From: "David S. Miller" <davem@davemloft.net>
To: drow@false.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH]: PTRACE_PEEKUSER redux...
Date: Fri, 07 Apr 2006 21:35:00 -0000 [thread overview]
Message-ID: <20060407.143506.67883777.davem@davemloft.net> (raw)
In-Reply-To: <20060407131622.GA20181@nevyn.them.org>
From: Daniel Jacobowitz <drow@false.org>
Date: Fri, 7 Apr 2006 09:16:23 -0400
> On Thu, Apr 06, 2006 at 10:03:57PM -0700, David S. Miller wrote:
> > In all cases, no matter what ptrace operation is specified, if the
> > child does not exist the error return we will get is -ESRCH (task not
> > found for pid) or -EPERM (trying to trace init or similar).
>
> This relies on all platforms doing the permission check before the
> operation check. Well, I guess it's still better than what we had
> before, right?
I definitely think so.
> > 2006-04-06 David S. Miller <davem@sunset.davemloft.net>
> >
> > * linux-nat.c (linux_nat_thread_alive): Thread is alive
> > as long as errno is neither -ESRCH nor -EPERM. This allows
> > to handle cleanly the case where PTRACE_PEEKUSER is not
> > a supported ptrace operation for a given Linux target.
>
> OK, except, please reverse the changelog and the patch :-) This
> comment should be in the source code, or we'll break it again later.
Ok, will do. Thanks a lot for reviewing.
prev parent reply other threads:[~2006-04-07 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 5:04 David S. Miller
2006-04-07 13:16 ` Daniel Jacobowitz
2006-04-07 21:35 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060407.143506.67883777.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox