From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31465 invoked by alias); 7 Apr 2006 21:35:46 -0000 Received: (qmail 31456 invoked by uid 22791); 7 Apr 2006 21:35:45 -0000 X-Spam-Check-By: sourceware.org Received: from dsl027-180-168.sfo1.dsl.speakeasy.net (HELO sunset.davemloft.net) (216.27.180.168) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 07 Apr 2006 21:35:43 +0000 Received: from localhost ([127.0.0.1] ident=davem) by sunset.davemloft.net with esmtp (Exim 4.60) (envelope-from ) id 1FRybp-0000jS-7a; Fri, 07 Apr 2006 14:35:13 -0700 Date: Fri, 07 Apr 2006 21:35:00 -0000 Message-Id: <20060407.143506.67883777.davem@davemloft.net> To: drow@false.org Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: PTRACE_PEEKUSER redux... From: "David S. Miller" In-Reply-To: <20060407131622.GA20181@nevyn.them.org> References: <20060406.220357.102230498.davem@davemloft.net> <20060407131622.GA20181@nevyn.them.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00092.txt.bz2 From: Daniel Jacobowitz Date: Fri, 7 Apr 2006 09:16:23 -0400 > On Thu, Apr 06, 2006 at 10:03:57PM -0700, David S. Miller wrote: > > In all cases, no matter what ptrace operation is specified, if the > > child does not exist the error return we will get is -ESRCH (task not > > found for pid) or -EPERM (trying to trace init or similar). > > This relies on all platforms doing the permission check before the > operation check. Well, I guess it's still better than what we had > before, right? I definitely think so. > > 2006-04-06 David S. Miller > > > > * linux-nat.c (linux_nat_thread_alive): Thread is alive > > as long as errno is neither -ESRCH nor -EPERM. This allows > > to handle cleanly the case where PTRACE_PEEKUSER is not > > a supported ptrace operation for a given Linux target. > > OK, except, please reverse the changelog and the patch :-) This > comment should be in the source code, or we'll break it again later. Ok, will do. Thanks a lot for reviewing.