Re: [PATCH]: Fix thread debugging on Sparc/Linux

[Daniel Jacobowitz <drow@false.org>]

On Tue, Apr 04, 2006 at 02:54:55PM -0700, David S. Miller wrote:
> From: "David S. Miller" <davem@davemloft.net>
> Date: Sat, 01 Apr 2006 23:12:03 -0800 (PST)
> 
> > Normally the {supply,fill}_{gregset,fpregset}() functions don't
> > get used on Sparc/Linux because all of the register stuff does
> > ptrace() inside of sparc-nat.c
> > 
> > However, for proc-service.c thread debugging (and I think also
> > for core files) these routines do get used.

Yes, it looks like they will currently be used for core regsets on
SPARC.  They shouldn't be; the Linux port could use an update to the
new regset mechanism, used by e.g. the BSDs.  That could add
cross-debug support for core files also.

They are also used for thread debugging, but that's general
GDB-for-Linux lameness; that part of linux-thread-db.c needs to be
eliminated.  It's on the todo list.

> > Currently, we're linking in sparc-sol2-nat.o but that doesn't
> > work so well because it hardcodes using the sparc_sol2_gregset
> > which causes no end of troubles if used on another native Sparc
> > platform.
> > 
> > Any objections to the following fix?
> 
> Since there were no objections, I've checked in the fix.

Thanks.  But, in the future, could you please wait for your patches to
be reviewed like everyone else (or ask to be the maintainer for this
port)?

You added includes to source files, so Makefile.in needs to be updated.

-- 
Daniel Jacobowitz
CodeSourcery