From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18478 invoked by alias); 4 Apr 2006 22:06:52 -0000 Received: (qmail 18468 invoked by uid 22791); 4 Apr 2006 22:06:51 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 04 Apr 2006 22:06:50 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FQtfk-00039M-4h; Tue, 04 Apr 2006 18:06:48 -0400 Date: Tue, 04 Apr 2006 22:06:00 -0000 From: Daniel Jacobowitz To: "David S. Miller" Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH]: Fix thread debugging on Sparc/Linux Message-ID: <20060404220648.GA11871@nevyn.them.org> Mail-Followup-To: "David S. Miller" , gdb-patches@sources.redhat.com References: <20060401.231203.48434968.davem@davemloft.net> <20060404.145455.31557955.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060404.145455.31557955.davem@davemloft.net> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00036.txt.bz2 On Tue, Apr 04, 2006 at 02:54:55PM -0700, David S. Miller wrote: > From: "David S. Miller" > Date: Sat, 01 Apr 2006 23:12:03 -0800 (PST) > > > Normally the {supply,fill}_{gregset,fpregset}() functions don't > > get used on Sparc/Linux because all of the register stuff does > > ptrace() inside of sparc-nat.c > > > > However, for proc-service.c thread debugging (and I think also > > for core files) these routines do get used. Yes, it looks like they will currently be used for core regsets on SPARC. They shouldn't be; the Linux port could use an update to the new regset mechanism, used by e.g. the BSDs. That could add cross-debug support for core files also. They are also used for thread debugging, but that's general GDB-for-Linux lameness; that part of linux-thread-db.c needs to be eliminated. It's on the todo list. > > Currently, we're linking in sparc-sol2-nat.o but that doesn't > > work so well because it hardcodes using the sparc_sol2_gregset > > which causes no end of troubles if used on another native Sparc > > platform. > > > > Any objections to the following fix? > > Since there were no objections, I've checked in the fix. Thanks. But, in the future, could you please wait for your patches to be reviewed like everyone else (or ask to be the maintainer for this port)? You added includes to source files, so Makefile.in needs to be updated. -- Daniel Jacobowitz CodeSourcery