Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Bail out of Thumb unwinding if there is no symbol
Date: Thu, 30 Mar 2006 17:15:00 -0000	[thread overview]
Message-ID: <20060330164856.GG32409@nevyn.them.org> (raw)
In-Reply-To: <1140516048.27380.10.camel@pc960.cambridge.arm.com>

On Tue, Feb 21, 2006 at 10:00:48AM +0000, Richard Earnshaw wrote:
> On Mon, 2006-02-20 at 21:42, Daniel Jacobowitz wrote:
> > If find_pc_partial_function fails, prologue_start won't have been
> > initialized.  The previous effect of this code was to try to disassemble at
> > 0 (by luck, the variable was unset).  This patch just stops unwinding when
> > we're stuck in a Thumb function without a symbol.
> > 
> > The astute may notice that it's a bit tricky to get to this situation
> > with current GDB; if we don't have symbols, how do we know that we're
> > Thumb?  Well, there's a couple ways to do it, including another
> > patch that I'm about to post.
> > 
> > This seems like an improvement over the current situation.  Lightly tested;
> > OK?
> 
> OK.

Thanks, committed.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2006-03-30 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20 21:45 Daniel Jacobowitz
2006-02-21 10:26 ` Richard Earnshaw
2006-03-30 17:15   ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060330164856.GG32409@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox