From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6484 invoked by alias); 30 Mar 2006 16:48:59 -0000 Received: (qmail 6475 invoked by uid 22791); 30 Mar 2006 16:48:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 30 Mar 2006 16:48:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FP0KO-0000Vs-Vv for gdb-patches@sourceware.org; Thu, 30 Mar 2006 11:48:57 -0500 Date: Thu, 30 Mar 2006 17:15:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFA] Bail out of Thumb unwinding if there is no symbol Message-ID: <20060330164856.GG32409@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060220214206.GA28728@nevyn.them.org> <1140516048.27380.10.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1140516048.27380.10.camel@pc960.cambridge.arm.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00372.txt.bz2 On Tue, Feb 21, 2006 at 10:00:48AM +0000, Richard Earnshaw wrote: > On Mon, 2006-02-20 at 21:42, Daniel Jacobowitz wrote: > > If find_pc_partial_function fails, prologue_start won't have been > > initialized. The previous effect of this code was to try to disassemble at > > 0 (by luck, the variable was unset). This patch just stops unwinding when > > we're stuck in a Thumb function without a symbol. > > > > The astute may notice that it's a bit tricky to get to this situation > > with current GDB; if we don't have symbols, how do we know that we're > > Thumb? Well, there's a couple ways to do it, including another > > patch that I'm about to post. > > > > This seems like an improvement over the current situation. Lightly tested; > > OK? > > OK. Thanks, committed. -- Daniel Jacobowitz CodeSourcery