From: Daniel Jacobowitz <drow@false.org>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA:] sim/common/aclocal.m4: correct duplicate arg test for --enable-sim-hardware=...
Date: Tue, 28 Mar 2006 22:40:00 -0000 [thread overview]
Message-ID: <20060328222721.GB11817@nevyn.them.org> (raw)
In-Reply-To: <200603251622.k2PGMwcQ002238@ignucius.se.axis.com>
On Sat, Mar 25, 2006 at 05:22:58PM +0100, Hans-Peter Nilsson wrote:
> - case " $f " in
> - x) ;;
> - *" $i "*) ;;
> + case " $sim_hw,$i " in
> + *",x "* | *" $i,"*) ;;
> *) sim_hw="$sim_hw $i" ; sim_hw_objs="$sim_hw_objs dv-$i.o";;
I don't think that's right. Don't you want:
for i in $hardware ; do
case " $sim_hw " in
*" $i "*) ;;
*) sim_hw="$sim_hw $i" ; sim_hw_objs="$sim_hw_objs dv-$i.o";;
esac
done
The "in x $hardware" bit is not necessary (that's only necessary from
Makefiles), and the commas don't work like you'd think, since sim_hw is
space separated.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-03-28 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-26 8:15 Hans-Peter Nilsson
2006-03-28 22:40 ` Daniel Jacobowitz [this message]
2006-03-29 15:43 ` Hans-Peter Nilsson
2006-03-29 15:49 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060328222721.GB11817@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox