From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23468 invoked by alias); 28 Mar 2006 22:27:25 -0000 Received: (qmail 23460 invoked by uid 22791); 28 Mar 2006 22:27:24 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Mar 2006 22:27:23 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FOMen-0003CG-Uc; Tue, 28 Mar 2006 17:27:22 -0500 Date: Tue, 28 Mar 2006 22:40:00 -0000 From: Daniel Jacobowitz To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: [RFA:] sim/common/aclocal.m4: correct duplicate arg test for --enable-sim-hardware=... Message-ID: <20060328222721.GB11817@nevyn.them.org> Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <200603251622.k2PGMwcQ002238@ignucius.se.axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200603251622.k2PGMwcQ002238@ignucius.se.axis.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00329.txt.bz2 On Sat, Mar 25, 2006 at 05:22:58PM +0100, Hans-Peter Nilsson wrote: > - case " $f " in > - x) ;; > - *" $i "*) ;; > + case " $sim_hw,$i " in > + *",x "* | *" $i,"*) ;; > *) sim_hw="$sim_hw $i" ; sim_hw_objs="$sim_hw_objs dv-$i.o";; I don't think that's right. Don't you want: for i in $hardware ; do case " $sim_hw " in *" $i "*) ;; *) sim_hw="$sim_hw $i" ; sim_hw_objs="$sim_hw_objs dv-$i.o";; esac done The "in x $hardware" bit is not necessary (that's only necessary from Makefiles), and the commas don't work like you'd think, since sim_hw is space separated. -- Daniel Jacobowitz CodeSourcery