From: Daniel Jacobowitz <drow@false.org>
To: Jim Blandy <jimb@red-bean.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: parse 'target remote' device special cases first
Date: Sat, 25 Mar 2006 07:18:00 -0000 [thread overview]
Message-ID: <20060325070020.GK26748@nevyn.them.org> (raw)
In-Reply-To: <vt2bqwgscgf.fsf@theseus.home.>
On Wed, Mar 08, 2006 at 04:12:32PM -0800, Jim Blandy wrote:
>
> Without this change, if the command supplied after 'target remote |'
> contained a colon, the portion of the command ahead of that colon
> would be mistaken for a hostname. But the syntax isn't actually
> ambiguous, since hostnames don't start with '|'.
>
> Tested on x86_64-pc-linux-gnu.
>
> src/gdb/ChangeLog:
> 2006-03-08 Jim Blandy <jimb@red-bean.com>
>
> * serial.c (serial_open): Check for special cases at the front of
> the "device" name before scanning for the ':' that would indicate
> an IP-based connection.
Doesn't this go against the "what not why" ChangeLog convention? It
ought to go in serial_open as a comment, I think.
Other than that, I agree; this patch is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-03-25 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 4:38 Jim Blandy
2006-03-25 7:18 ` Daniel Jacobowitz [this message]
2006-04-11 20:32 ` Jim Blandy
2006-04-11 20:42 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060325070020.GK26748@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox