From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13378 invoked by alias); 25 Mar 2006 07:00:32 -0000 Received: (qmail 13311 invoked by uid 22791); 25 Mar 2006 07:00:31 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 25 Mar 2006 07:00:27 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FN2l2-0007Uy-RL; Sat, 25 Mar 2006 02:00:20 -0500 Date: Sat, 25 Mar 2006 07:18:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: parse 'target remote' device special cases first Message-ID: <20060325070020.GK26748@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00287.txt.bz2 On Wed, Mar 08, 2006 at 04:12:32PM -0800, Jim Blandy wrote: > > Without this change, if the command supplied after 'target remote |' > contained a colon, the portion of the command ahead of that colon > would be mistaken for a hostname. But the syntax isn't actually > ambiguous, since hostnames don't start with '|'. > > Tested on x86_64-pc-linux-gnu. > > src/gdb/ChangeLog: > 2006-03-08 Jim Blandy > > * serial.c (serial_open): Check for special cases at the front of > the "device" name before scanning for the ':' that would indicate > an IP-based connection. Doesn't this go against the "what not why" ChangeLog convention? It ought to go in serial_open as a comment, I think. Other than that, I agree; this patch is OK. -- Daniel Jacobowitz CodeSourcery