Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Clean up proc-service includes in gdbserver
Date: Wed, 15 Mar 2006 22:36:00 -0000	[thread overview]
Message-ID: <20060315195122.GA21298@nevyn.them.org> (raw)
In-Reply-To: <44186F79.3090704@redhat.com>

On Wed, Mar 15, 2006 at 11:48:09AM -0800, Michael Snyder wrote:
> Daniel Jacobowitz wrote:
> >A while ago, I posted MIPS and ARM NPTL support for gdbserver.
> >Before I got around to checking it in, Mark K. looked at one of
> >them and went "ewwww..."; it was just copied from three other places
> >in gdbserver, but I totally agree with his reaction.  So this patch
> >un-ewwws things a bit.  Instead of borrowing gdb_proc_service.h
> >from gdb, this patch gives gdbserver its own, slightly different
> >copy.
> >
> >We don't use the prfpregset_t functions at all, so we can lose some
> >old autoconf checks, too.
> >
> >Tested and committed.
> >
> 
> If gdb_proc_service.h is shared between gdb and gdbserver,
> should we move it up to ../include/gdb?

That might be a good idea if they wanted to keep the same versions,
yes; but I've just diverged them, which I think will be simpler.
The GDB copy includes "gregset.h" and messes around with bits
from the GDB native configuration - bit hard to reuse.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-03-15 19:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-15 16:36 Daniel Jacobowitz
2006-03-15 22:28 ` Michael Snyder
2006-03-15 22:36   ` Daniel Jacobowitz [this message]
2006-03-15 22:39 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060315195122.GA21298@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox