From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5019 invoked by alias); 15 Mar 2006 19:51:26 -0000 Received: (qmail 4970 invoked by uid 22791); 15 Mar 2006 19:51:25 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 15 Mar 2006 19:51:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FJc1i-0005Yf-WD; Wed, 15 Mar 2006 14:51:23 -0500 Date: Wed, 15 Mar 2006 22:36:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sourceware.org Subject: Re: [commit] Clean up proc-service includes in gdbserver Message-ID: <20060315195122.GA21298@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sourceware.org References: <20060315161633.GA15527@nevyn.them.org> <44186F79.3090704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44186F79.3090704@redhat.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00202.txt.bz2 On Wed, Mar 15, 2006 at 11:48:09AM -0800, Michael Snyder wrote: > Daniel Jacobowitz wrote: > >A while ago, I posted MIPS and ARM NPTL support for gdbserver. > >Before I got around to checking it in, Mark K. looked at one of > >them and went "ewwww..."; it was just copied from three other places > >in gdbserver, but I totally agree with his reaction. So this patch > >un-ewwws things a bit. Instead of borrowing gdb_proc_service.h > >from gdb, this patch gives gdbserver its own, slightly different > >copy. > > > >We don't use the prfpregset_t functions at all, so we can lose some > >old autoconf checks, too. > > > >Tested and committed. > > > > If gdb_proc_service.h is shared between gdb and gdbserver, > should we move it up to ../include/gdb? That might be a good idea if they wanted to keep the same versions, yes; but I've just diverged them, which I think will be simpler. The GDB copy includes "gregset.h" and messes around with bits from the GDB native configuration - bit hard to reuse. -- Daniel Jacobowitz CodeSourcery