From: Daniel Jacobowitz <drow@false.org>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Prelink.exp troubles
Date: Tue, 07 Mar 2006 19:34:00 -0000 [thread overview]
Message-ID: <20060307172307.GA1474@nevyn.them.org> (raw)
In-Reply-To: <orirqqrgnj.fsf@free.oliva.athome.lsd.ic.unicamp.br>
On Tue, Mar 07, 2006 at 02:02:40AM -0300, Alexandre Oliva wrote:
> > And, when matching
> > patterns in gdb_test_multiple (the same was true in gdb_expect)
> > it's important to anchor the end of the pattern to the GDB prompt.
> > Otherwise that prompt might not be consumed by expect, causing
> > new tests added at the end of the file to fail.
>
> Oh? I thought gdb_test_multiple would only exit when it got to a
> prompt or something, so it would be consumed automatically. Is that
> not so?
Take a look at the implementation, or other uses, please. If a
user-procided case does not use exp_continue, the function will return.
> > If you agree about the UNTESTED, with those changes it's fine to check
> > in. My test runs thank you.
>
> Here's what I'm checking in, in the hopes that the archoring you
> suggested above is not needed, otherwise I'll take care of it in a
> subsequent patch.
Please fix the anchoring.
Thanks,
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-03-07 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 20:05 Daniel Jacobowitz
2006-03-03 14:49 ` Alexandre Oliva
2006-03-06 18:38 ` Daniel Jacobowitz
2006-03-07 8:38 ` Alexandre Oliva
2006-03-07 19:34 ` Daniel Jacobowitz [this message]
2006-03-09 4:40 ` Alexandre Oliva
2006-03-25 7:02 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060307172307.GA1474@nevyn.them.org \
--to=drow@false.org \
--cc=aoliva@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox