From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28080 invoked by alias); 7 Mar 2006 17:23:13 -0000 Received: (qmail 28068 invoked by uid 22791); 7 Mar 2006 17:23:12 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 07 Mar 2006 17:23:10 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FGfts-0000ud-HQ; Tue, 07 Mar 2006 12:23:08 -0500 Date: Tue, 07 Mar 2006 19:34:00 -0000 From: Daniel Jacobowitz To: Alexandre Oliva Cc: gdb-patches@sourceware.org Subject: Re: Prelink.exp troubles Message-ID: <20060307172307.GA1474@nevyn.them.org> Mail-Followup-To: Alexandre Oliva , gdb-patches@sourceware.org References: <20060301200540.GE6465@nevyn.them.org> <20060304151105.GE20187@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00116.txt.bz2 On Tue, Mar 07, 2006 at 02:02:40AM -0300, Alexandre Oliva wrote: > > And, when matching > > patterns in gdb_test_multiple (the same was true in gdb_expect) > > it's important to anchor the end of the pattern to the GDB prompt. > > Otherwise that prompt might not be consumed by expect, causing > > new tests added at the end of the file to fail. > > Oh? I thought gdb_test_multiple would only exit when it got to a > prompt or something, so it would be consumed automatically. Is that > not so? Take a look at the implementation, or other uses, please. If a user-procided case does not use exp_continue, the function will return. > > If you agree about the UNTESTED, with those changes it's fine to check > > in. My test runs thank you. > > Here's what I'm checking in, in the hopes that the archoring you > suggested above is not needed, otherwise I'll take care of it in a > subsequent patch. Please fix the anchoring. Thanks, -- Daniel Jacobowitz CodeSourcery