Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: rearnsha@arm.com, gdb-patches@sourceware.org, sjackman@gmail.com
Subject: Re: RFC: Use the ARM CPSR as a fallback to determine ARM/Thumb
Date: Thu, 02 Mar 2006 23:23:00 -0000	[thread overview]
Message-ID: <20060302231302.GB22458@nevyn.them.org> (raw)
In-Reply-To: <200603022251.k22Mps0w023981@elgar.sibelius.xs4all.nl>

On Thu, Mar 02, 2006 at 11:51:54PM +0100, Mark Kettenis wrote:
> > On Thu, Mar 02, 2006 at 11:22:26PM +0100, Mark Kettenis wrote:
> > > Hmm, this really should unwind CPSR from the frame I think.  A bit
> > > impractical to change that now, but something to keep in mind.  Could
> > > you add a FIXME that points this out if you agree?
> > 
> > But... what frame?  Is there a relevant frame?  I don't believe that
> > there is.  This is used for things like breakpoints and explicit "x/i".
> > Maybe you see something I don't, though?
> 
> It is possible for thumb code and "normal" code to coexist in a single
> address space isn't it?

Certainly.

> The prologue analyzer seems to use this, so if we're doing a
> backtrace, I think it should use the CPSR value for that frame,
> instead of whatever the current value for that register is.

The CPSR is not saved and restored in the frame.  We could pretend that
it was, and manually stitch together the T bit from the return address,
I suppose - the low bit will already be set in the PC for Thumb so this
won't trigger for that case, only for backtracing into an ARM function
via Thumb.  But I see your point now.  I will take another look at this
later, to see if I can get it righter.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-03-02 23:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20 22:03 Daniel Jacobowitz
2006-02-21 15:36 ` Richard Earnshaw
2006-02-21 16:10   ` Daniel Jacobowitz
2006-03-02 22:23     ` Daniel Jacobowitz
2006-03-02 22:52       ` Mark Kettenis
2006-03-02 23:02         ` Daniel Jacobowitz
2006-03-02 23:10           ` Mark Kettenis
2006-03-02 23:23             ` Daniel Jacobowitz [this message]
2008-05-01 18:38       ` Daniel Jacobowitz
2008-05-02 10:17         ` Eli Zaretskii
2008-05-02 14:06           ` Daniel Jacobowitz
2008-05-02 15:47             ` Eli Zaretskii
2008-05-02 16:03               ` Daniel Jacobowitz
2008-05-02 20:34                 ` Eli Zaretskii
2006-02-25 11:12 ` Jim Blandy
2006-02-26 13:10   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060302231302.GB22458@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=rearnsha@arm.com \
    --cc=sjackman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox