Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: gdb-patches@sourceware.org, Shaun Jackman <sjackman@gmail.com>
Subject: Re: RFC: Use the ARM CPSR as a fallback to determine ARM/Thumb
Date: Tue, 21 Feb 2006 16:10:00 -0000	[thread overview]
Message-ID: <20060221153601.GA21183@nevyn.them.org> (raw)
In-Reply-To: <1140519913.27380.29.camel@pc960.cambridge.arm.com>

On Tue, Feb 21, 2006 at 11:05:13AM +0000, Richard Earnshaw wrote:
> I can sympathise... :-)  Also note that for a lot of ARM users,
> defaulting to ARM is exactly the wrong choice, since all their code is
> Thumb (with the possible exception of some start-up code and other small
> trampolines).  I think that guessing based on the current CPSR is a
> better guess than just ARM, if you can sort out the 'what we guessed
> last time we looked at this address problem...'.

OK, I will fix up the patch.

> > Maybe there should be a "set" option for the default when no symbol is
> > found, allowing the user to throttle this back to ARM-only if that works
> > better for them?
> 
> I certainly think we need a set option, but it's more complex than that,
> since I think it needs probably four states:
> 
> arm        - force to ARM mode even if things look otherwise.
> thumb      - force to Thumb mode even if things look otherwise.
> auto-arm   - Try to work it out, but guess ARM if unknown
> auto-thumb - Try to work it out, but guess Thumb if unknown
> 
> Another approach would be some augmentation to a memory-region type
> command, something like
> 
> add code-region [arm|thumb|auto-arm|auto-thumb] <base> [+<extent>|<limit>]

What I had in mind for this was:

set arm fallback-mode [arm|thumb|auto]

That is, continue to honor symbol information, but change the fallback
when we don't have symbols to arm, thumb, or current cpsr.

And maybe augment that with:

set arm force-mode [arm|thumb|auto]

This would also override symbol information.

This is basically the same as your first option, but spread out over
two variables.  How does that sound?

I'd rather avoid regions here; they're complicated, and not a very
useful way to describe arm/thumb mixing.  Hmm, software single step
probably gets very confused over mode changes; not going to touch that
right now though.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-02-21 15:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-20 22:03 Daniel Jacobowitz
2006-02-21 15:36 ` Richard Earnshaw
2006-02-21 16:10   ` Daniel Jacobowitz [this message]
2006-03-02 22:23     ` Daniel Jacobowitz
2006-03-02 22:52       ` Mark Kettenis
2006-03-02 23:02         ` Daniel Jacobowitz
2006-03-02 23:10           ` Mark Kettenis
2006-03-02 23:23             ` Daniel Jacobowitz
2008-05-01 18:38       ` Daniel Jacobowitz
2008-05-02 10:17         ` Eli Zaretskii
2008-05-02 14:06           ` Daniel Jacobowitz
2008-05-02 15:47             ` Eli Zaretskii
2008-05-02 16:03               ` Daniel Jacobowitz
2008-05-02 20:34                 ` Eli Zaretskii
2006-02-25 11:12 ` Jim Blandy
2006-02-26 13:10   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060221153601.GA21183@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=rearnsha@arm.com \
    --cc=sjackman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox