From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] mn10300-tdep.c: Always write return address to MDR register on push_dummy_call
Date: Thu, 02 Mar 2006 09:31:00 -0000 [thread overview]
Message-ID: <20060302093144.GA3184@calimero.vinschen.de> (raw)
In-Reply-To: <4406037A.6020307@redhat.com>
On Mar 1 12:26, Michael Snyder wrote:
> Corinna Vinschen wrote:
> >Hi,
> >
> >the mn10300 hardware always writes the return address to the stack and
> >into the MDR register when any "call" machine instruction is executed.
> >The mn10300_push_dummy_call function does only write the return address
> >to the stack, which might result into problems when leaf functions are
> >called and the MDR register is known not to be clobbered by "mul" or
> >"div" instructions. The below patch also writes the return address
> >always into the MDR register, like the hardware.
> >
> >Ok to apply?
>
> Ha, yes, nice catch. ;-)
Thanks, applied.
> > * mn10300-tdep.c (mn10300_push_dummy_call): Write breakpoint
> > address to MDR register.
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
prev parent reply other threads:[~2006-03-02 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 17:27 Corinna Vinschen
2006-03-01 20:26 ` Michael Snyder
2006-03-02 9:31 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302093144.GA3184@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox